From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18441 invoked by alias); 27 May 2010 20:09:36 -0000 Received: (qmail 18421 invoked by uid 22791); 27 May 2010 20:09:35 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 May 2010 20:09:28 +0000 Received: (qmail 4541 invoked from network); 27 May 2010 20:09:27 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 May 2010 20:09:27 -0000 From: Pedro Alves To: tromey@redhat.com Subject: Re: [RFA] New qRelocInsn RSP packet, docs and NEWS. Date: Thu, 27 May 2010 20:14:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-21-generic; KDE/4.3.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201005241435.45703.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005272109.22413.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00658.txt.bz2 On Thursday 27 May 2010 20:58:02, Tom Tromey wrote: > >>>>> "Pedro" == Pedro Alves writes: > > Pedro> Index: src/gdb/remote.c > Pedro> =================================================================== > Pedro> --- src.orig/gdb/remote.c 2010-05-24 12:28:42.000000000 +0100 > Pedro> +++ src/gdb/remote.c 2010-05-24 13:14:56.000000000 +0100 > Pedro> @@ -242,6 +242,8 @@ static void remote_terminal_ours (void); > > Pedro> static int remote_read_description_p (struct target_ops *target); > > Pedro> +char *unpack_varlen_hex (char *buff, ULONGEST *result); > > It seems like this declaration could go in tracepoint.h. This function does live in remote.c, but it's defined further down, close to its siblings. tracepoint.c is also reusing it since not to long ago (since tracing moved to target_ops). remote.h would make a bit more sense though one could argue it could also live in a shared utils.c-kind of file nowadays. -- Pedro Alves