From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb.gdb/*.exp send_gdb vs. gdb_test
Date: Wed, 26 May 2010 18:04:00 -0000 [thread overview]
Message-ID: <20100526175743.GD3019@adacore.com> (raw)
In-Reply-To: <4BFC4117.5020003@vmware.com>
> 2010-05-25 Michael Snyder <msnyder@vmware.com>
>
> * gdb.gdb/complaints.exp: Replace send_gdb with gdb_test.
> * gdb.gdb/selftest.exp: Replace send_gdb with gdb_test.
> * gdb.gdb/xfullpath.exp: Replace send_gdb with gdb_test.
Same question as before: Can you double-check that gdb_test cannot
be used in the cases below? If not, OK to commit.
> # Add a second complaint, expect it
> - send_gdb "call complaint (&symfile_complaints, \"serial line 2\")\n"
> - gdb_expect {
> + gdb_test_multiple "call complaint (&symfile_complaints, \"serial line 2\")" "serial line 2" {
> -re "serial line 2...$gdb_prompt " {
> pass "serial line 2"
> }
> - "$gdb_prompt" {
> - fail "serial line 2"
> - }
> - timeout {
> - fail "serial line 2 (timeout)"
> - }
Can we use gdb_test here?
> - send_gdb "call complaint (&symfile_complaints, \"short line 1\")\n"
> - gdb_expect {
> + gdb_test_multiple "call complaint (&symfile_complaints, \"short line 1\")" "short line 1" {
> -re "short line 1...$gdb_prompt " {
> pass "short line 1"
Ditto?
> # Add a second complaint, expect it
> - send_gdb "call complaint (&symfile_complaints, \"short line 2\")\n"
> - gdb_expect {
> + gdb_test_multiple "call complaint (&symfile_complaints, \"short line 2\")" "short line 2" {
Ditto again.
--
Joel
next prev parent reply other threads:[~2010-05-26 17:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 21:43 Michael Snyder
2010-05-26 18:04 ` Joel Brobecker [this message]
2010-05-26 18:26 ` Michael Snyder
2010-05-26 18:28 ` Joel Brobecker
2010-05-26 18:44 ` Michael Snyder
2010-05-26 18:45 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526175743.GD3019@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox