From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6960 invoked by alias); 26 May 2010 17:58:01 -0000 Received: (qmail 6949 invoked by uid 22791); 26 May 2010 17:58:00 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 May 2010 17:57:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2F3D92BABBE; Wed, 26 May 2010 13:57:55 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3UnJgEmoBLDA; Wed, 26 May 2010 13:57:55 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BC0632BABB3; Wed, 26 May 2010 13:57:54 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 05278F58FA; Wed, 26 May 2010 10:57:44 -0700 (PDT) Date: Wed, 26 May 2010 18:04:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [RFA] gdb.gdb/*.exp send_gdb vs. gdb_test Message-ID: <20100526175743.GD3019@adacore.com> References: <4BFC4117.5020003@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BFC4117.5020003@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00608.txt.bz2 > 2010-05-25 Michael Snyder > > * gdb.gdb/complaints.exp: Replace send_gdb with gdb_test. > * gdb.gdb/selftest.exp: Replace send_gdb with gdb_test. > * gdb.gdb/xfullpath.exp: Replace send_gdb with gdb_test. Same question as before: Can you double-check that gdb_test cannot be used in the cases below? If not, OK to commit. > # Add a second complaint, expect it > - send_gdb "call complaint (&symfile_complaints, \"serial line 2\")\n" > - gdb_expect { > + gdb_test_multiple "call complaint (&symfile_complaints, \"serial line 2\")" "serial line 2" { > -re "serial line 2...$gdb_prompt " { > pass "serial line 2" > } > - "$gdb_prompt" { > - fail "serial line 2" > - } > - timeout { > - fail "serial line 2 (timeout)" > - } Can we use gdb_test here? > - send_gdb "call complaint (&symfile_complaints, \"short line 1\")\n" > - gdb_expect { > + gdb_test_multiple "call complaint (&symfile_complaints, \"short line 1\")" "short line 1" { > -re "short line 1...$gdb_prompt " { > pass "short line 1" Ditto? > # Add a second complaint, expect it > - send_gdb "call complaint (&symfile_complaints, \"short line 2\")\n" > - gdb_expect { > + gdb_test_multiple "call complaint (&symfile_complaints, \"short line 2\")" "short line 2" { Ditto again. -- Joel