From: Pedro Alves <pedro@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb.base/c*.exp, send_gdb vs. gdb_test
Date: Sun, 23 May 2010 21:40:00 -0000 [thread overview]
Message-ID: <201005232215.53133.pedro@codesourcery.com> (raw)
In-Reply-To: <4BF98448.5030805@vmware.com>
On Sunday 23 May 2010 20:38:48, Michael Snyder wrote:
> >> - send_gdb "call str_func1(s)\n"
> >> - gdb_expect {
> >> - -re "first string arg is: test string.*\"test string\".*$gdb_prompt $" {
> >> - pass "call str_func1(s)"
> >> - }
> >> - -re ".*$gdb_prompt $" { fail "call str_func1(s)" }
> >> - timeout { fail "(timeout) call str_func1(s)" }
> >> - }
> >> + gdb_test "call str_func1(s)" \
> >
> > The previous test output didn't have the extra space. Could you
> > remove it? There are several instances of this.
>
> What extra space are you talking about?
'pass "call str_func1(s)"' vs 'gdb_test "call str_func1(s)"'
^ ^^
Your gdb_test didn't have an explicit message, so the command
string is used as replacement. If gdb.sum diffing didn't reveal
this, I missed something obvious. :-) Anyway, just a nit.
--
Pedro Alves
next prev parent reply other threads:[~2010-05-23 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 22:33 Michael Snyder
2010-05-23 1:40 ` Pedro Alves
2010-05-23 20:15 ` Michael Snyder
2010-05-23 21:40 ` Pedro Alves [this message]
2010-05-24 22:07 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005232215.53133.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox