From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21349 invoked by alias); 23 May 2010 21:16:01 -0000 Received: (qmail 21339 invoked by uid 22791); 23 May 2010 21:16:01 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 23 May 2010 21:15:57 +0000 Received: (qmail 22062 invoked from network); 23 May 2010 21:15:55 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 May 2010 21:15:55 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: [RFA] gdb.base/c*.exp, send_gdb vs. gdb_test Date: Sun, 23 May 2010 21:40:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-21-generic; KDE/4.3.2; x86_64; ; ) Cc: "gdb-patches@sourceware.org" References: <4BF84A62.40806@vmware.com> <201005222335.58505.pedro@codesourcery.com> <4BF98448.5030805@vmware.com> In-Reply-To: <4BF98448.5030805@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201005232215.53133.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00543.txt.bz2 On Sunday 23 May 2010 20:38:48, Michael Snyder wrote: > >> - send_gdb "call str_func1(s)\n" > >> - gdb_expect { > >> - -re "first string arg is: test string.*\"test string\".*$gdb_prompt $" { > >> - pass "call str_func1(s)" > >> - } > >> - -re ".*$gdb_prompt $" { fail "call str_func1(s)" } > >> - timeout { fail "(timeout) call str_func1(s)" } > >> - } > >> + gdb_test "call str_func1(s)" \ > > > > The previous test output didn't have the extra space. Could you > > remove it? There are several instances of this. > > What extra space are you talking about? 'pass "call str_func1(s)"' vs 'gdb_test "call str_func1(s)"' ^ ^^ Your gdb_test didn't have an explicit message, so the command string is used as replacement. If gdb.sum diffing didn't reveal this, I missed something obvious. :-) Anyway, just a nit. -- Pedro Alves