From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>
Subject: Re: [RFA] gdb.base/whatis-exp.exp: replace send_gdb with gdb_test
Date: Wed, 19 May 2010 18:57:00 -0000 [thread overview]
Message-ID: <201005191956.10614.pedro@codesourcery.com> (raw)
In-Reply-To: <4BF42C8D.2070002@vmware.com>
On Wednesday 19 May 2010 19:23:09, Michael Snyder wrote:
> Some clean-up by replacing old-style "send_gdb / gdb_expect" with
> gdb_test.
Looks good, but please don't align things vertically with extra spaces
like that. (It's more distracting than good, IMO, and has the effect
that whoever adds a longer line that breaks the alignment is tempted to
realign all other lines to keep things consistent, thus introducing
spurious changes.)
--
Pedro Alves
prev parent reply other threads:[~2010-05-19 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 18:56 Michael Snyder
2010-05-19 18:57 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005191956.10614.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox