From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29035 invoked by alias); 19 May 2010 18:56:36 -0000 Received: (qmail 29020 invoked by uid 22791); 19 May 2010 18:56:35 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 May 2010 18:56:30 +0000 Received: (qmail 8561 invoked from network); 19 May 2010 18:56:28 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 19 May 2010 18:56:28 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] gdb.base/whatis-exp.exp: replace send_gdb with gdb_test Date: Wed, 19 May 2010 18:57:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-21-generic; KDE/4.3.2; x86_64; ; ) Cc: Michael Snyder References: <4BF42C8D.2070002@vmware.com> In-Reply-To: <4BF42C8D.2070002@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201005191956.10614.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00393.txt.bz2 On Wednesday 19 May 2010 19:23:09, Michael Snyder wrote: > Some clean-up by replacing old-style "send_gdb / gdb_expect" with > gdb_test. Looks good, but please don't align things vertically with extra spaces like that. (It's more distracting than good, IMO, and has the effect that whoever adds a longer line that breaks the alignment is tempted to realign all other lines to keep things consistent, thus introducing spurious changes.) -- Pedro Alves