From: Pedro Alves <pedro@codesourcery.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'Joel Brobecker'" <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] Add watchpoint hit address function to procfs.c
Date: Mon, 10 May 2010 21:49:00 -0000 [thread overview]
Message-ID: <201005102249.20383.pedro@codesourcery.com> (raw)
In-Reply-To: <001801caf088$4d8a7ae0$e89f70a0$@muller@ics-cnrs.unistra.fr>
On Monday 10 May 2010 22:32:33, Pierre Muller wrote:
> Those failure are a problem within the watchthreads.exp
> source, the test uses '\r' patterns without the '\n' as is usual...
> If I replace all '\r' by '\r+' then there are no failures left
> for that test.
> I ran again both versions (with TIDGET or plain zero)
> and got exactly the same output for both. Thus, apparently the
> thread number is not necessary to get the location of the
> watchpoint even if it is not in the main thread (for my OpenSolaris version
> at least...)
Okay, thanks for taking the trouble to confirm this. Since it was
working before, let's drop that change for now. I don't want to
change things we don't exactly understand, as we may be breaking
something else. If we ever figure out why watchpoints in non-main
threads work as is, we should add a comment explaining it.
--
Pedro Alves
next prev parent reply other threads:[~2010-05-10 21:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 14:17 Pierre Muller
2010-05-07 15:25 ` Pedro Alves
2010-05-08 16:46 ` Pierre Muller
2010-05-08 17:24 ` Pedro Alves
2010-05-10 7:16 ` Pierre Muller
2010-05-10 19:27 ` Pedro Alves
2010-05-10 21:23 ` Joel Brobecker
2010-05-12 2:31 ` Reformat procfs.c (was: Re: [RFC] Add watchpoint hit address function to procfs.c) Pedro Alves
2010-05-17 10:50 ` Pedro Alves
2010-05-10 21:33 ` [RFC] Add watchpoint hit address function to procfs.c Pierre Muller
2010-05-10 21:49 ` Pedro Alves [this message]
2010-05-10 22:19 ` [RFA] " Pierre Muller
2010-05-11 11:49 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005102249.20383.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox