From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24180 invoked by alias); 10 May 2010 21:49:39 -0000 Received: (qmail 24172 invoked by uid 22791); 10 May 2010 21:49:38 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 May 2010 21:49:34 +0000 Received: (qmail 3129 invoked from network); 10 May 2010 21:49:33 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 May 2010 21:49:33 -0000 From: Pedro Alves To: "Pierre Muller" Subject: Re: [RFC] Add watchpoint hit address function to procfs.c Date: Mon, 10 May 2010 21:49:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: "'Joel Brobecker'" , gdb-patches@sourceware.org References: <006601cae54b$368452f0$a38cf8d0$@muller@ics-cnrs.unistra.fr> <201005102027.10080.pedro@codesourcery.com> <001801caf088$4d8a7ae0$e89f70a0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <001801caf088$4d8a7ae0$e89f70a0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005102249.20383.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00235.txt.bz2 On Monday 10 May 2010 22:32:33, Pierre Muller wrote: > Those failure are a problem within the watchthreads.exp > source, the test uses '\r' patterns without the '\n' as is usual... > If I replace all '\r' by '\r+' then there are no failures left > for that test. > I ran again both versions (with TIDGET or plain zero) > and got exactly the same output for both. Thus, apparently the > thread number is not necessary to get the location of the > watchpoint even if it is not in the main thread (for my OpenSolaris version > at least...) Okay, thanks for taking the trouble to confirm this. Since it was working before, let's drop that change for now. I don't want to change things we don't exactly understand, as we may be breaking something else. If we ever figure out why watchpoints in non-main threads work as is, we should add a comment explaining it. -- Pedro Alves