* [OB] eliminate unused local
@ 2010-05-05 18:55 Michael Snyder
2010-05-05 19:01 ` Pedro Alves
0 siblings, 1 reply; 4+ messages in thread
From: Michael Snyder @ 2010-05-05 18:55 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: tmp1.txt --]
[-- Type: text/plain, Size: 717 bytes --]
2010-05-05 Michael Snyder <msnyder@vmware.com>
* features/i386/i386-mmx.c (initialize_tdesc_i386_mmx):
Delete unused variable 'type'.
Index: features/i386/i386-mmx.c
===================================================================
RCS file: /cvs/src/src/gdb/features/i386/i386-mmx.c,v
retrieving revision 1.1
diff -u -p -r1.1 i386-mmx.c
--- features/i386/i386-mmx.c 8 Apr 2010 22:32:38 -0000 1.1
+++ features/i386/i386-mmx.c 5 May 2010 18:53:08 -0000
@@ -10,7 +10,6 @@ initialize_tdesc_i386_mmx (void)
{
struct target_desc *result = allocate_target_description ();
struct tdesc_feature *feature;
- struct tdesc_type *field_type, *type;
set_tdesc_architecture (result, bfd_scan_arch ("i386"));
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OB] eliminate unused local
2010-05-05 18:55 [OB] eliminate unused local Michael Snyder
@ 2010-05-05 19:01 ` Pedro Alves
2010-05-05 19:06 ` Michael Snyder
0 siblings, 1 reply; 4+ messages in thread
From: Pedro Alves @ 2010-05-05 19:01 UTC (permalink / raw)
To: gdb-patches; +Cc: Michael Snyder
On Wednesday 05 May 2010 19:55:36, Michael Snyder wrote:
> 2010-05-05 Michael Snyder <msnyder@vmware.com>
>
> * features/i386/i386-mmx.c (initialize_tdesc_i386_mmx):
> Delete unused variable 'type'.
The patch also deleted `field_type'. But in any case, this
is a generated file; you should fix the source of the problem
instead.
>
> Index: features/i386/i386-mmx.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/features/i386/i386-mmx.c,v
> retrieving revision 1.1
> diff -u -p -r1.1 i386-mmx.c
> --- features/i386/i386-mmx.c 8 Apr 2010 22:32:38 -0000 1.1
> +++ features/i386/i386-mmx.c 5 May 2010 18:53:08 -0000
> @@ -10,7 +10,6 @@ initialize_tdesc_i386_mmx (void)
> {
> struct target_desc *result = allocate_target_description ();
> struct tdesc_feature *feature;
> - struct tdesc_type *field_type, *type;
>
> set_tdesc_architecture (result, bfd_scan_arch ("i386"));
>
--
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OB] eliminate unused local
2010-05-05 19:01 ` Pedro Alves
@ 2010-05-05 19:06 ` Michael Snyder
2010-05-05 20:32 ` Pedro Alves
0 siblings, 1 reply; 4+ messages in thread
From: Michael Snyder @ 2010-05-05 19:06 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
Pedro Alves wrote:
> On Wednesday 05 May 2010 19:55:36, Michael Snyder wrote:
>> 2010-05-05 Michael Snyder <msnyder@vmware.com>
>>
>> * features/i386/i386-mmx.c (initialize_tdesc_i386_mmx):
>> Delete unused variable 'type'.
>
> The patch also deleted `field_type'. But in any case, this
> is a generated file; you should fix the source of the problem
> instead.
Oops, where is it generated from?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OB] eliminate unused local
2010-05-05 19:06 ` Michael Snyder
@ 2010-05-05 20:32 ` Pedro Alves
0 siblings, 0 replies; 4+ messages in thread
From: Pedro Alves @ 2010-05-05 20:32 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
On Wednesday 05 May 2010 20:06:11, Michael Snyder wrote:
> Pedro Alves wrote:
> > On Wednesday 05 May 2010 19:55:36, Michael Snyder wrote:
> >> 2010-05-05 Michael Snyder <msnyder@vmware.com>
> >>
> >> * features/i386/i386-mmx.c (initialize_tdesc_i386_mmx):
> >> Delete unused variable 'type'.
> >
> > The patch also deleted `field_type'. But in any case, this
> > is a generated file; you should fix the source of the problem
> > instead.
>
> Oops, where is it generated from?
From what is written in the first line of the file. See the
comments in features/Makefile to see how to regenerate it.
--
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-05 20:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-05 18:55 [OB] eliminate unused local Michael Snyder
2010-05-05 19:01 ` Pedro Alves
2010-05-05 19:06 ` Michael Snyder
2010-05-05 20:32 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox