Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix has_section_at_zero for separate debug files
Date: Wed, 28 Apr 2010 22:40:00 -0000	[thread overview]
Message-ID: <20100428154023.4036c51b@redhat.com> (raw)
In-Reply-To: <20100107130918.GA11037@chinon.act-europe.fr>

On Thu, 7 Jan 2010 14:09:18 +0100
Tristan Gingold <gingold@ACT-Europe.FR> wrote:

> 2010-01-07  Tristan Gingold  <gingold@adacore.com>
> 
> 	* dwarf2read.c (dwarf2_locate_sections): Also consider SEC_ALLOC
> 	sections to set has_section_at_zero.
> 	(dwarf2_psymtab_to_symtab): Do not copy has_section_at_zero from
> 	backlink for separate debug file.

Tristan's patch causes no regressions for the gdb.base/sepdebug.exp
test, for which I had used a different approach for fixing problems
for that I was seeing when testing a mep-elf toolchain.

Tristan's patch reverts my earlier work and uses a different approach
to ensure that `has_section_at_zero' is set correctly.  I endorse this
approach and think that this patch should be committed.

Kevin


  parent reply	other threads:[~2010-04-28 22:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07 13:09 Tristan Gingold
2010-01-11 21:29 ` Tom Tromey
2010-01-12  5:01   ` Kevin Buettner
2010-01-12  8:56     ` Tristan Gingold
2010-04-19 20:27     ` Joel Brobecker
2010-01-12  8:55   ` Tristan Gingold
2010-04-28 22:40 ` Kevin Buettner [this message]
2010-05-05 18:43   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100428154023.4036c51b@redhat.com \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox