From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 591 invoked by alias); 28 Apr 2010 22:40:33 -0000 Received: (qmail 574 invoked by uid 22791); 28 Apr 2010 22:40:31 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Apr 2010 22:40:26 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3SMeO99009432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Apr 2010 18:40:24 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3SMeOdp015281 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Wed, 28 Apr 2010 18:40:24 -0400 Date: Wed, 28 Apr 2010 22:40:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [RFA] Fix has_section_at_zero for separate debug files Message-ID: <20100428154023.4036c51b@redhat.com> In-Reply-To: <20100107130918.GA11037@chinon.act-europe.fr> References: <20100107130918.GA11037@chinon.act-europe.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00946.txt.bz2 On Thu, 7 Jan 2010 14:09:18 +0100 Tristan Gingold wrote: > 2010-01-07 Tristan Gingold > > * dwarf2read.c (dwarf2_locate_sections): Also consider SEC_ALLOC > sections to set has_section_at_zero. > (dwarf2_psymtab_to_symtab): Do not copy has_section_at_zero from > backlink for separate debug file. Tristan's patch causes no regressions for the gdb.base/sepdebug.exp test, for which I had used a different approach for fixing problems for that I was seeing when testing a mep-elf toolchain. Tristan's patch reverts my earlier work and uses a different approach to ensure that `has_section_at_zero' is set correctly. I endorse this approach and think that this patch should be committed. Kevin