From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: New ARI warning Fri Apr 23 02:18:56 UTC 2010
Date: Fri, 23 Apr 2010 12:37:00 -0000 [thread overview]
Message-ID: <20100423123649.GL19194@adacore.com> (raw)
In-Reply-To: <20100423021857.GA22323@sourceware.org>
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
> > gdb/ppc-linux-nat.c:1511: code: inline: Do not use the inline attribute; since the compiler generally ignores this, better algorithm selection is needed to improved performance
> gdb/ppc-linux-nat.c:1511:static inline int
I checked in the attached patch to get rid of this new warning...
2010-04-23 Joel Brobecker <brobecker@adacore.com>
Fix ARI warning.
* ppc-linux-nat.c (booke_cmp_hw_point): Do not mark inline.
--
Joel
[-- Attachment #2: inline.diff --]
[-- Type: text/x-diff, Size: 607 bytes --]
Index: ppc-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/ppc-linux-nat.c,v
retrieving revision 1.93
diff -u -u -p -r1.93 ppc-linux-nat.c
--- ppc-linux-nat.c 22 Apr 2010 22:26:36 -0000 1.93
+++ ppc-linux-nat.c 23 Apr 2010 12:34:10 -0000
@@ -1508,7 +1508,7 @@ ppc_linux_region_ok_for_hw_watchpoint (C
}
/* This function compares two ppc_hw_breakpoint structs field-by-field. */
-static inline int
+static int
booke_cmp_hw_point (struct ppc_hw_breakpoint *a, struct ppc_hw_breakpoint *b)
{
return (a->trigger_type == b->trigger_type
prev parent reply other threads:[~2010-04-23 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 2:19 GDB Administrator
2010-04-23 12:37 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423123649.GL19194@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox