From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32449 invoked by alias); 23 Apr 2010 12:37:00 -0000 Received: (qmail 32441 invoked by uid 22791); 23 Apr 2010 12:36:59 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Apr 2010 12:36:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AE7092BACD7 for ; Fri, 23 Apr 2010 08:36:50 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HPPseXAsEXmx for ; Fri, 23 Apr 2010 08:36:50 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4C31B2BAD01 for ; Fri, 23 Apr 2010 08:36:50 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0EAABF5895; Fri, 23 Apr 2010 05:36:50 -0700 (PDT) Date: Fri, 23 Apr 2010 12:37:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: New ARI warning Fri Apr 23 02:18:56 UTC 2010 Message-ID: <20100423123649.GL19194@adacore.com> References: <20100423021857.GA22323@sourceware.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="udcq9yAoWb9A4FsZ" Content-Disposition: inline In-Reply-To: <20100423021857.GA22323@sourceware.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00786.txt.bz2 --udcq9yAoWb9A4FsZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 450 > > gdb/ppc-linux-nat.c:1511: code: inline: Do not use the inline attribute; since the compiler generally ignores this, better algorithm selection is needed to improved performance > gdb/ppc-linux-nat.c:1511:static inline int I checked in the attached patch to get rid of this new warning... 2010-04-23 Joel Brobecker Fix ARI warning. * ppc-linux-nat.c (booke_cmp_hw_point): Do not mark inline. -- Joel --udcq9yAoWb9A4FsZ Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="inline.diff" Content-length: 607 Index: ppc-linux-nat.c =================================================================== RCS file: /cvs/src/src/gdb/ppc-linux-nat.c,v retrieving revision 1.93 diff -u -u -p -r1.93 ppc-linux-nat.c --- ppc-linux-nat.c 22 Apr 2010 22:26:36 -0000 1.93 +++ ppc-linux-nat.c 23 Apr 2010 12:34:10 -0000 @@ -1508,7 +1508,7 @@ ppc_linux_region_ok_for_hw_watchpoint (C } /* This function compares two ppc_hw_breakpoint structs field-by-field. */ -static inline int +static int booke_cmp_hw_point (struct ppc_hw_breakpoint *a, struct ppc_hw_breakpoint *b) { return (a->trigger_type == b->trigger_type --udcq9yAoWb9A4FsZ--