Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Fix bug report 11479
Date: Wed, 21 Apr 2010 15:11:00 -0000	[thread overview]
Message-ID: <20100421151117.GA13675@adacore.com> (raw)
In-Reply-To: <20100413152823.GG19194@adacore.com>

> >   But this is the trouble,
> > the chain was not cycled before my patch, 
> > and thus the 'const type' was never resolved and its length
> > was still left at zero.
> >   I didn't really get what the loop line 4465
> > is supposed to do, but it only operates on LOC_TYPEDEF,
> > and on the file_symbol level, not at argument list of functions...

Pierre - I understand now what you were trying to say.  The problem in
this situation is that there are no global variable of the type that
we need to fix.

I think that the proper solution would be to enhance function
cleanup_undefined_types_1 to also look at symbols inside function
symbols.  That way, the problem should be fixed for all kinds of
types, not just structs...

The following should work: In the loop over file_symbols, check
the symbol type: If it is a function, then get the function block,
and iterate again on all symbols inside that block. If not a function,
then we match the symbol itself.  We will probably need to move the
symbol matching condition to its own function to avoid duplication...

-- 
Joel


  reply	other threads:[~2010-04-21 15:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 20:40 Pierre Muller
2010-04-12 15:55 ` Joel Brobecker
2010-04-12 16:22   ` Pierre Muller
2010-04-13 15:28     ` Joel Brobecker
2010-04-21 15:11       ` Joel Brobecker [this message]
2010-04-21 21:11         ` Pierre Muller
2010-04-22  1:11           ` Joel Brobecker
2010-04-22 10:20             ` [RFA-v2] " Pierre Muller
2010-04-22 12:20               ` Joel Brobecker
2010-04-22 13:03                 ` Pierre Muller
2010-04-22 13:26                   ` Joel Brobecker
2010-04-22 13:39                     ` Pierre Muller
     [not found] <37072.6329427727$1270759254@news.gmane.org>
2010-04-09 15:55 ` [RFC] " Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100421151117.GA13675@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox