From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Joel Brobecker'" <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA-v2] Fix bug report 11479
Date: Thu, 22 Apr 2010 13:39:00 -0000 [thread overview]
Message-ID: <002201cae221$1c899fe0$559cdfa0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20100422132635.GK19194@adacore.com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : Thursday, April 22, 2010 3:27 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA-v2] Fix bug report 11479
>
> > > > +gdb_exit
> > >
> > > Harmless, but unnecessary. Let's toss it.
> > Removed at the end, but reintroduced below...
>
> Hmmm, yes, that's right - on Windows, the filesystem locks the files
> being opened.
I think that there still is a place inside the testsuite where
the same problem appears...
> > I am not convinced that a second round using default compiler debug
> > settings is really useful, unless the same bug reappears once in
> > another debug format, which is pretty unlikely.
>
> Probably a fair comment, but since stabs is pretty much doomed, this
> allows us to reuse the test even after stabs support gets removed
> (or on platforms where stabs is not supported).
>
> > 2010-04-22 Pierre Muller <muller@ics.u-strasbg.fr>
> >
> > PR stabs/11479.
> > * gdb.stabs/gdb11479.exp: New file.
> > * gdb.stabs/gdb11479.c: New file.
>
> This is OK.
Thanks for the review,
committed.
Pierre
prev parent reply other threads:[~2010-04-22 13:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 20:40 [RFC] " Pierre Muller
2010-04-12 15:55 ` Joel Brobecker
2010-04-12 16:22 ` Pierre Muller
2010-04-13 15:28 ` Joel Brobecker
2010-04-21 15:11 ` Joel Brobecker
2010-04-21 21:11 ` Pierre Muller
2010-04-22 1:11 ` Joel Brobecker
2010-04-22 10:20 ` [RFA-v2] " Pierre Muller
2010-04-22 12:20 ` Joel Brobecker
2010-04-22 13:03 ` Pierre Muller
2010-04-22 13:26 ` Joel Brobecker
2010-04-22 13:39 ` Pierre Muller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002201cae221$1c899fe0$559cdfa0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox