Re: [RFA] [3/4] Mingw64 gdbserver support

[Pedro Alves <pedro@codesourcery.com>]

On Monday 19 April 2010 23:58:55, Pierre Muller wrote:
> gdbserver/configure.srv part of the patch.
> 
> 
> 
> Pierre Muller
> Pascal language support maintainer for GDB
> 
> 2010-04-19  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>         * configure.srv (x86_64-*-mingw*): New configuration for Windows 
>         64-bit executables.

Weren't you going to s/x86_64-w64-mingw/x86_64-*-mingw/  ?  The ChangeLog
mentions the latter, but the patch does the former.

>         Set srv_mingw64 variable to `yes'.

Why is this needed?  I don't see anywhere in the patch series
using it.  Wasn't this needed in the older version to have configure.ac
link with -lws2_32 for this config only, but it's not needed anymore?

> 
> Index: gdbserver/configure.srv
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
> retrieving revision 1.54
> diff -u -p -r1.54 configure.srv
> --- gdbserver/configure.srv     19 Apr 2010 14:08:05 -0000      1.54
> +++ gdbserver/configure.srv     19 Apr 2010 22:42:53 -0000
> @@ -231,6 +231,13 @@ case "${target}" in
>                         srv_linux_regsets=yes
>                         srv_linux_thread_db=yes
>                         ;;
> +  x86_64-w64-mingw*)   srv_regobj="$srv_amd64_regobj"
> +                       srv_tgtobj="i386-low.o i387-fp.o win32-low.o
> win32-i386-low.o"
> +                       srv_xmlfiles="$srv_i386_xmlfiles
> $srv_amd64_xmlfiles"
> +                       srv_mingw64=yes
> +                       srv_mingw=yes
> +                       ;;
> +
>    xscale*-*-linux*)    srv_regobj=reg-arm.o
>                         srv_tgtobj="linux-low.o linux-arm-low.o"
>                         srv_linux_usrregs=yes
> 


-- 
Pedro Alves