From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72268-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12850 invoked by alias); 19 Apr 2010 23:30:33 -0000
Received: (qmail 12841 invoked by uid 22791); 19 Apr 2010 23:30:33 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Apr 2010 23:30:28 +0000
Received: (qmail 8970 invoked from network); 19 Apr 2010 23:30:26 -0000
Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 19 Apr 2010 23:30:26 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [RFA] [3/4] Mingw64 gdbserver support
Date: Mon, 19 Apr 2010 23:30:00 -0000
User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; )
Cc: gdb-patches@sourceware.org
References: <001501cae013$e3e53410$abaf9c30$@muller@ics-cnrs.unistra.fr>
In-Reply-To: <001501cae013$e3e53410$abaf9c30$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: Text/Plain;   charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201004200030.23956.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00587.txt.bz2

On Monday 19 April 2010 23:58:55, Pierre Muller wrote:
> gdbserver/configure.srv part of the patch.
> 
> 
> 
> Pierre Muller
> Pascal language support maintainer for GDB
> 
> 2010-04-19  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>         * configure.srv (x86_64-*-mingw*): New configuration for Windows 
>         64-bit executables.

Weren't you going to s/x86_64-w64-mingw/x86_64-*-mingw/  ?  The ChangeLog
mentions the latter, but the patch does the former.

>         Set srv_mingw64 variable to `yes'.

Why is this needed?  I don't see anywhere in the patch series
using it.  Wasn't this needed in the older version to have configure.ac
link with -lws2_32 for this config only, but it's not needed anymore?

> 
> Index: gdbserver/configure.srv
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
> retrieving revision 1.54
> diff -u -p -r1.54 configure.srv
> --- gdbserver/configure.srv     19 Apr 2010 14:08:05 -0000      1.54
> +++ gdbserver/configure.srv     19 Apr 2010 22:42:53 -0000
> @@ -231,6 +231,13 @@ case "${target}" in
>                         srv_linux_regsets=yes
>                         srv_linux_thread_db=yes
>                         ;;
> +  x86_64-w64-mingw*)   srv_regobj="$srv_amd64_regobj"
> +                       srv_tgtobj="i386-low.o i387-fp.o win32-low.o
> win32-i386-low.o"
> +                       srv_xmlfiles="$srv_i386_xmlfiles
> $srv_amd64_xmlfiles"
> +                       srv_mingw64=yes
> +                       srv_mingw=yes
> +                       ;;
> +
>    xscale*-*-linux*)    srv_regobj=reg-arm.o
>                         srv_tgtobj="linux-low.o linux-arm-low.o"
>                         srv_linux_usrregs=yes
> 


-- 
Pedro Alves