From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] testsuite: Simplify + make more safe sepdebug
Date: Mon, 19 Apr 2010 16:26:00 -0000 [thread overview]
Message-ID: <20100419162605.GT19194@adacore.com> (raw)
In-Reply-To: <20100419122801.GA14177@host0.dyn.jankratochvil.net>
> gdb/testsuite/
> 2010-04-19 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.base/break-interp.exp: Remove $exec.debug safety removal.
> * gdb.base/sepdebug.exp: Remove .debug subdirectory handling. New
> variable different_dir. Move debugfile into a full directory pathname
> under DIFFERENT_DIR.
> * lib/gdb.exp (separate_debug_filename): Remove.
> (gdb_gnu_strip_debug): No longer call separate_debug_filename. Remove
> variable debug_dir and mkdir of it. Update function comments.
This does make sense to me - although I don't know off hand the reason
for having initially chosen to put the .debug file in a separate
directory. Maybe there is more to it.
The patch is fine for me, but let's give it a week to give people a chance
to object....
> + # Use the first separate debug info file location searched by GDB so the
> + # run cannot be breaken by some stale file searched with higher precedence.
^^^^^^^ broken
--
Joel
next prev parent reply other threads:[~2010-04-19 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 12:28 Jan Kratochvil
2010-04-19 16:26 ` Joel Brobecker [this message]
2010-05-02 9:10 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100419162605.GT19194@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox