From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20544 invoked by alias); 19 Apr 2010 16:26:19 -0000 Received: (qmail 20528 invoked by uid 22791); 19 Apr 2010 16:26:17 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Apr 2010 16:26:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5C2162BAB4F; Mon, 19 Apr 2010 12:26:07 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DCvginV8pn3v; Mon, 19 Apr 2010 12:26:07 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 786C62BABA3; Mon, 19 Apr 2010 12:26:05 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 30A3BF5895; Mon, 19 Apr 2010 09:26:05 -0700 (PDT) Date: Mon, 19 Apr 2010 16:26:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Simplify + make more safe sepdebug Message-ID: <20100419162605.GT19194@adacore.com> References: <20100419122801.GA14177@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100419122801.GA14177@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00562.txt.bz2 > gdb/testsuite/ > 2010-04-19 Jan Kratochvil > > * gdb.base/break-interp.exp: Remove $exec.debug safety removal. > * gdb.base/sepdebug.exp: Remove .debug subdirectory handling. New > variable different_dir. Move debugfile into a full directory pathname > under DIFFERENT_DIR. > * lib/gdb.exp (separate_debug_filename): Remove. > (gdb_gnu_strip_debug): No longer call separate_debug_filename. Remove > variable debug_dir and mkdir of it. Update function comments. This does make sense to me - although I don't know off hand the reason for having initially chosen to put the .debug file in a separate directory. Maybe there is more to it. The patch is fine for me, but let's give it a week to give people a chance to object.... > + # Use the first separate debug info file location searched by GDB so the > + # run cannot be breaken by some stale file searched with higher precedence. ^^^^^^^ broken -- Joel