From: Mike Frysinger <vapier@gentoo.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: add --model-info helper option
Date: Mon, 19 Apr 2010 18:41:00 -0000 [thread overview]
Message-ID: <201004191441.23256.vapier@gentoo.org> (raw)
In-Reply-To: <w2se394668d1004180047of57c9e11o2659f7c73d58b617@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 669 bytes --]
On Sunday 18 April 2010 03:47:34 Doug Evans wrote:
> I believe you want NULL for the doc member of "info-model":
>
> + { {"info-model", no_argument, NULL, OPTION_MODEL_INFO},
> + '\0', NULL, "List selectable models",
>
> "List selectable models" should be NULL.
> At least according to sim-options.h:
>
> If DOC is NULL, this option name is listed as a synonym for the
> previous option.
cool, i wasnt aware of this feature
> Also, I think you want the last printf of "\n" inside the outer for loop:
>
> + sim_io_printf (sd, "\n");
indeed
> This patch is ok with these changes.
OK, committed then, thanks
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2010-04-19 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 7:32 Mike Frysinger
2010-04-18 7:47 ` Doug Evans
2010-04-19 18:41 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004191441.23256.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox