From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27728 invoked by alias); 19 Apr 2010 18:41:31 -0000 Received: (qmail 27717 invoked by uid 22791); 19 Apr 2010 18:41:30 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Apr 2010 18:41:26 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 66B561B409D; Mon, 19 Apr 2010 18:41:24 +0000 (UTC) From: Mike Frysinger To: Doug Evans Subject: Re: [PATCH] sim: add --model-info helper option Date: Mon, 19 Apr 2010 18:41:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33.2; KDE/4.4.1; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <1271403092-21679-1-git-send-email-vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2503543.xJk8Yf5i2E"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201004191441.23256.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00570.txt.bz2 --nextPart2503543.xJk8Yf5i2E Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 653 On Sunday 18 April 2010 03:47:34 Doug Evans wrote: > I believe you want NULL for the doc member of "info-model": >=20 > + { {"info-model", no_argument, NULL, OPTION_MODEL_INFO}, > + '\0', NULL, "List selectable models", >=20 > "List selectable models" should be NULL. > At least according to sim-options.h: >=20 > If DOC is NULL, this option name is listed as a synonym for the > previous option. cool, i wasnt aware of this feature > Also, I think you want the last printf of "\n" inside the outer for loop: >=20 > + sim_io_printf (sd, "\n"); indeed > This patch is ok with these changes. OK, committed then, thanks -mike --nextPart2503543.xJk8Yf5i2E Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLzKPTAAoJEEFjO5/oN/WBuqQQAMyW9w57i3j8ffju81GJ89sq /jcbQCRFYzDVPPN4ABQOvPd3qcxR8QPmFeMPd8UsduqheR4yYLpJeV/HLpNnDEND frII56NZqoBbqRffWlGjqY54EAahq4gfpxXtDxH7iXMCLExKChO7Mcn9AUyytJbz iRFZKhxK5sYkdNPLrTSvV/2JW2Y0OIRJxXDfl9B5KKb7hLjJgGhHi0f0W/bP1ulm KgGyq/ifpNhTwdhF91A0C6KPnGJneNpneM/stV7uxD2RhQsiskcF5qXwbipn2yi/ aLqTFiy9SHe7UfC4GysheLvE+HSPmovp893SR/2qUd6tgJggiGG6lZFHwFHJ8mFB 4HI1/UjhvfmCqIRAXMzNQ4XHCx4zd3ZEYmuqykfsV8kNguKx0+2iV0zQ8LZthYa5 c8/8CwbfSUOVBxD4cNuMQLV3erunEIgPMbIdlnmAjDFzE9Y7cNBwlPOHzaruL5eW FOvKw2s2CcPwv+I+Bl/A/mqc+TXGeZzEhJhXk6gAF7BITBriXVpvmaX4qGEg5Fmt ooZQQGKtchzbrGZppoP4RkBSYRsFC9+fXxwlg/xVqcQTW/Cj4wlb/cD6YjodooCo KgJyWhs8CZ94omBtN+RcY2fTVS/LCqoaQyyXqtWG1prYKNz4fw35/8Pad9OPM161 YTzY230sgaQtZD1xm3KJ =aSTw -----END PGP SIGNATURE----- --nextPart2503543.xJk8Yf5i2E--