Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: hjl.tools@gmail.com
Cc: gdb-patches@sourceware.org
Subject: Re: PATCH: PR corefiles/11511: gcore doesn't work with orig_rax on  Linux/amd64
Date: Sat, 17 Apr 2010 16:25:00 -0000	[thread overview]
Message-ID: <201004171625.o3HGPc93029549@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20100417161115.GA25919@intel.com> (hongjiu.lu@intel.com)

> Date: Sat, 17 Apr 2010 09:11:15 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> 
> This patch adds orig_rax support to amd64_linux_gregset_reg_offset.
> amd64 has both tdep->gregset_reg_offset/tdep->gregset_num_regs and
> amd64_native_gregset64_reg_offset/amd64_native_gregset64_num_regs.  They 
> are identical. There is no need to keep both.  This patch also removes
> amd64_native_gregset64_reg_offset/amd64_native_gregset64_num_regs. OK
> to install?

No.  I want to keep the -nat.c and -tdep.c code separate.

The bit below is ok, but please drop the other bits.

> 	* amd64-linux-tdep.c (amd64_linux_gregset_reg_offset): Support
> 	orig_rax.

> diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
> index 1205e31..f249d5d 100644
> --- a/gdb/amd64-linux-tdep.c
> +++ b/gdb/amd64-linux-tdep.c
> @@ -87,7 +87,14 @@ static int amd64_linux_gregset_reg_offset[] =
>    23 * 8,			/* %ds */
>    24 * 8,			/* %es */
>    25 * 8,			/* %fs */
> -  26 * 8			/* %gs */
> +  26 * 8,			/* %gs */
> +  -1, -1, -1, -1, -1, -1, -1, -1,
> +  -1, -1, -1, -1, -1, -1, -1, -1,
> +  -1, -1, -1, -1, -1, -1, -1, -1,
> +  -1, -1, -1, -1, -1, -1, -1, -1, -1,
> +  -1, -1, -1, -1, -1, -1, -1, -1,
> +  -1, -1, -1, -1, -1, -1, -1, -1,
> +  15 * 8			/* "orig_rax" */
>  };
>  \f
>  


  reply	other threads:[~2010-04-17 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-17 16:11 H.J. Lu
2010-04-17 16:25 ` Mark Kettenis [this message]
2010-04-17 18:50   ` H.J. Lu
2010-04-18 21:33     ` Mark Kettenis
2010-04-19 15:26       ` Daniel Jacobowitz
2010-04-19 17:21       ` H.J. Lu
2010-04-19 17:28         ` H. Peter Anvin
2010-04-20 22:17           ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004171625.o3HGPc93029549@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox