From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15116 invoked by alias); 17 Apr 2010 16:25:52 -0000 Received: (qmail 15098 invoked by uid 22791); 17 Apr 2010 16:25:50 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Apr 2010 16:25:45 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o3HGPeNR007469; Sat, 17 Apr 2010 18:25:40 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o3HGPc93029549; Sat, 17 Apr 2010 18:25:38 +0200 (CEST) Date: Sat, 17 Apr 2010 16:25:00 -0000 Message-Id: <201004171625.o3HGPc93029549@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: hjl.tools@gmail.com CC: gdb-patches@sourceware.org In-reply-to: <20100417161115.GA25919@intel.com> (hongjiu.lu@intel.com) Subject: Re: PATCH: PR corefiles/11511: gcore doesn't work with orig_rax on Linux/amd64 References: <20100417161115.GA25919@intel.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00531.txt.bz2 > Date: Sat, 17 Apr 2010 09:11:15 -0700 > From: "H.J. Lu" > > This patch adds orig_rax support to amd64_linux_gregset_reg_offset. > amd64 has both tdep->gregset_reg_offset/tdep->gregset_num_regs and > amd64_native_gregset64_reg_offset/amd64_native_gregset64_num_regs. They > are identical. There is no need to keep both. This patch also removes > amd64_native_gregset64_reg_offset/amd64_native_gregset64_num_regs. OK > to install? No. I want to keep the -nat.c and -tdep.c code separate. The bit below is ok, but please drop the other bits. > * amd64-linux-tdep.c (amd64_linux_gregset_reg_offset): Support > orig_rax. > diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c > index 1205e31..f249d5d 100644 > --- a/gdb/amd64-linux-tdep.c > +++ b/gdb/amd64-linux-tdep.c > @@ -87,7 +87,14 @@ static int amd64_linux_gregset_reg_offset[] = > 23 * 8, /* %ds */ > 24 * 8, /* %es */ > 25 * 8, /* %fs */ > - 26 * 8 /* %gs */ > + 26 * 8, /* %gs */ > + -1, -1, -1, -1, -1, -1, -1, -1, > + -1, -1, -1, -1, -1, -1, -1, -1, > + -1, -1, -1, -1, -1, -1, -1, -1, > + -1, -1, -1, -1, -1, -1, -1, -1, -1, > + -1, -1, -1, -1, -1, -1, -1, -1, > + -1, -1, -1, -1, -1, -1, -1, -1, > + 15 * 8 /* "orig_rax" */ > }; > >