From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH]: gdb: fdpic/frv: fix shared library loading
Date: Fri, 16 Apr 2010 22:22:00 -0000 [thread overview]
Message-ID: <20100416152228.3c1df952@redhat.com> (raw)
In-Reply-To: <201004140259.39671.vapier@gentoo.org>
On Wed, 14 Apr 2010 02:59:38 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> 2010-04-14 Mike Frysinger <vapier@gentoo.org>
>
> * solib-frv.c (enable_break1_done): Delete.
> (enable_break2): Do not check enable_break1_done. Move the
> enable_break2_done setting and call to
> remove_solib_event_breakpoints() to the end. Return without
> warning when the contents of _dl_debug_addr are 0.
> (enable_break): Do not set enable_break1_done.
> (frv_clear_solib): Likewise.
Okay, except for...
> + /* First, remove all the solib event breakpoints. Their addresses
> + may have changed since the last time we ran the program. */
> + remove_solib_event_breakpoints ();
...this comment. Just change it to read "Remove all the solib...". (It's
not happening first anymore.)
Feel free to commit it after revising that comment.
Kevin
prev parent reply other threads:[~2010-04-16 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 7:00 Mike Frysinger
2010-04-15 15:25 ` Andrew Stubbs
2010-04-15 21:56 ` Mike Frysinger
2010-04-16 22:22 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416152228.3c1df952@redhat.com \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox