From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25651 invoked by alias); 16 Apr 2010 22:22:39 -0000 Received: (qmail 25622 invoked by uid 22791); 16 Apr 2010 22:22:38 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Apr 2010 22:22:32 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3GMMV9r007672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 16 Apr 2010 18:22:31 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3GMMSea006171 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Fri, 16 Apr 2010 18:22:29 -0400 Date: Fri, 16 Apr 2010 22:22:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH]: gdb: fdpic/frv: fix shared library loading Message-ID: <20100416152228.3c1df952@redhat.com> In-Reply-To: <201004140259.39671.vapier@gentoo.org> References: <201004140259.39671.vapier@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00522.txt.bz2 On Wed, 14 Apr 2010 02:59:38 -0400 Mike Frysinger wrote: > 2010-04-14 Mike Frysinger > > * solib-frv.c (enable_break1_done): Delete. > (enable_break2): Do not check enable_break1_done. Move the > enable_break2_done setting and call to > remove_solib_event_breakpoints() to the end. Return without > warning when the contents of _dl_debug_addr are 0. > (enable_break): Do not set enable_break1_done. > (frv_clear_solib): Likewise. Okay, except for... > + /* First, remove all the solib event breakpoints. Their addresses > + may have changed since the last time we ran the program. */ > + remove_solib_event_breakpoints (); ...this comment. Just change it to read "Remove all the solib...". (It's not happening first anymore.) Feel free to commit it after revising that comment. Kevin