Re: [PATCH]: New `logical*8' type for Fortran

[Jan Kratochvil <jan.kratochvil@redhat.com>]

Hi Sergio,

On Fri, 16 Apr 2010 01:01:21 +0200, Sergio Durigan Junior wrote:
> This patch has been in our tree for a while and we would like to see it 
> upstream.  Jan asked me to take care of this, so I would like to post it for 
> your appreciation.  Comments are welcome as usual.

sorry for follow-up from me:


> 2010-04-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* f-exp.y: Add new production to recognize the `logical*8' type.
> 	(LOGICAL_S8_KEYWORD): New token.
> 
> 	* f-lang.c (enum f_primitive_types)
> 	<f_primitive_type_logical_s8>: New field.
> 	(f_language_arch_info): Handling `logical*8' type.
> 	(build_fortran_types): Building `logical*8' type.
> 
> 	* f-lang.h (builtin_logical_s8): New struct.

It is a new field of struct builtin_f_type, not a new struct.

Also these changes depend each on the other so there should not be empty lines
between the changes.  (6.8.2 Style of Change Logs)


> gdb/testsuite/ChangeLog:
> 
> 2010-04-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.fortran/logical.exp: New testcase.
> 	* gdb.fortran/logical.f90: New file.

As you did some *.exp modifications you should list yourself here (in the case
you explicitly do not want to be listed there I do not know what the rules are).

> +++ b/gdb/testsuite/gdb.fortran/logical.exp
> +# Copyright 2007 Free Software Foundation, Inc.
> +++ b/gdb/testsuite/gdb.fortran/logical.f90
> +! Copyright 2008 Free Software Foundation, Inc.

The your should be changed as the patch was neither in FSF GDB nor in Archer.

> +! Ihis file is the Fortran source file for dynamic.exp.

This is not true.

> +! Original file written by Jakub Jelinek <jakub@redhat.com>.

This is not true (it was for dynamic.exp where the code size was not trivial).

> +! Modified for the GDB testcase by Jan Kratochvil 
> <jan.kratochvil@redhat.com>.

Patch lines are corrupted (wrapped) by your MUA (mail user agent).



Thanks,
Jan