From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11173 invoked by alias); 16 Apr 2010 06:09:28 -0000 Received: (qmail 11155 invoked by uid 22791); 16 Apr 2010 06:09:26 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Apr 2010 06:09:21 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3G69KNb008942 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 16 Apr 2010 02:09:20 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3G69HZi032619 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 16 Apr 2010 02:09:19 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o3G69HhC030160; Fri, 16 Apr 2010 08:09:17 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o3G69G8e030159; Fri, 16 Apr 2010 08:09:16 +0200 Date: Fri, 16 Apr 2010 06:09:00 -0000 From: Jan Kratochvil To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH]: New `logical*8' type for Fortran Message-ID: <20100416060916.GA29503@host0.dyn.jankratochvil.net> References: <201004152001.22206.sergiodj@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201004152001.22206.sergiodj@redhat.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00498.txt.bz2 Hi Sergio, On Fri, 16 Apr 2010 01:01:21 +0200, Sergio Durigan Junior wrote: > This patch has been in our tree for a while and we would like to see it > upstream. Jan asked me to take care of this, so I would like to post it for > your appreciation. Comments are welcome as usual. sorry for follow-up from me: > 2010-04-15 Jan Kratochvil > > * f-exp.y: Add new production to recognize the `logical*8' type. > (LOGICAL_S8_KEYWORD): New token. > > * f-lang.c (enum f_primitive_types) > : New field. > (f_language_arch_info): Handling `logical*8' type. > (build_fortran_types): Building `logical*8' type. > > * f-lang.h (builtin_logical_s8): New struct. It is a new field of struct builtin_f_type, not a new struct. Also these changes depend each on the other so there should not be empty lines between the changes. (6.8.2 Style of Change Logs) > gdb/testsuite/ChangeLog: > > 2010-04-15 Jan Kratochvil > > * gdb.fortran/logical.exp: New testcase. > * gdb.fortran/logical.f90: New file. As you did some *.exp modifications you should list yourself here (in the case you explicitly do not want to be listed there I do not know what the rules are). > +++ b/gdb/testsuite/gdb.fortran/logical.exp > +# Copyright 2007 Free Software Foundation, Inc. > +++ b/gdb/testsuite/gdb.fortran/logical.f90 > +! Copyright 2008 Free Software Foundation, Inc. The your should be changed as the patch was neither in FSF GDB nor in Archer. > +! Ihis file is the Fortran source file for dynamic.exp. This is not true. > +! Original file written by Jakub Jelinek . This is not true (it was for dynamic.exp where the code size was not trivial). > +! Modified for the GDB testcase by Jan Kratochvil > . Patch lines are corrupted (wrapped) by your MUA (mail user agent). Thanks, Jan