From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: constify sim_write source buffer
Date: Tue, 13 Apr 2010 15:35:00 -0000 [thread overview]
Message-ID: <20100413153532.GH19194@adacore.com> (raw)
In-Reply-To: <1270936687-26687-1-git-send-email-vapier@gentoo.org>
> include/gdb/:
> 2010-04-10 Mike Frysinger <vapier@gentoo.org>
>
> * remote-sim.h (sim_write): Add const to buf arg.
>
> sim/common/:
> 2010-04-10 Mike Frysinger <vapier@gentoo.org>
>
> * sim-hrw.c (sim_write): Add const to buf arg.
> * sim-utils.h (sim_write_fn): Likewise.
This is OK.
If you feel courageous, I noticed that the .h files in the include/gdb
subdirectory are still using the PARAMS macro. We stopped using them
a very long time ago... A patch removing them is pre-approved.
--
Joel
next prev parent reply other threads:[~2010-04-13 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 21:58 Mike Frysinger
2010-04-13 15:35 ` Joel Brobecker [this message]
2010-04-13 20:39 ` [PATCH] sim: drop PARAMS Mike Frysinger
2010-04-13 23:25 [PATCH] sim: constify sim_write source buffer Sandra Loosemore
2010-04-14 0:39 ` Mike Frysinger
2010-04-14 6:03 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413153532.GH19194@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox