From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32442 invoked by alias); 13 Apr 2010 15:35:56 -0000 Received: (qmail 32430 invoked by uid 22791); 13 Apr 2010 15:35:56 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Apr 2010 15:35:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A44FE2BABA5; Tue, 13 Apr 2010 11:35:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dmyjnuz8ySMg; Tue, 13 Apr 2010 11:35:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6FDB92BABA6; Tue, 13 Apr 2010 11:35:48 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8776BF58C2; Tue, 13 Apr 2010 08:35:32 -0700 (PDT) Date: Tue, 13 Apr 2010 15:35:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: constify sim_write source buffer Message-ID: <20100413153532.GH19194@adacore.com> References: <1270936687-26687-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1270936687-26687-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00409.txt.bz2 > include/gdb/: > 2010-04-10 Mike Frysinger > > * remote-sim.h (sim_write): Add const to buf arg. > > sim/common/: > 2010-04-10 Mike Frysinger > > * sim-hrw.c (sim_write): Add const to buf arg. > * sim-utils.h (sim_write_fn): Likewise. This is OK. If you feel courageous, I noticed that the .h files in the include/gdb subdirectory are still using the PARAMS macro. We stopped using them a very long time ago... A patch removing them is pre-approved. -- Joel