From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, Daniel Jacobowitz <dan@codesourcery.com>
Subject: Re: [patch, rfc] Re: MIPS dwarf2 location lists
Date: Mon, 12 Apr 2010 20:24:00 -0000 [thread overview]
Message-ID: <20100412202337.GD19194@adacore.com> (raw)
In-Reply-To: <201004091615.o39GFgl3032201@d12av02.megacenter.de.ibm.com>
> > * dwarf2expr.c (dwarf2_read_address): Make static.
> > * dwarf2expr.h (dwarf2_read_address): Remove prototype.
> > * dwarf2loc.c (find_location_expression): Add relocation offset
> > to base-address-selection entry base addresses. Read addresses
> > (and offsets) as signed/unsigned integers, depending on the
> > BFD's sign_extend_vma flag. Do not call dwarf2_read_address.
> > (locexpr_describe_location): Read TLS offset as unsigned
> > integer. Do not call dwarf2_read_address.
>
> Ping. Any thoughts on whether we should go with this?
Can't really say much about the patch itself; but FWIW, I tested it
on mips-irix, and saw no regression.
--
Joel
next prev parent reply other threads:[~2010-04-12 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 14:10 Daniel Jacobowitz
2010-02-18 16:47 ` Ulrich Weigand
2010-02-18 17:24 ` Daniel Jacobowitz
2010-02-18 19:20 ` Ulrich Weigand
2010-03-03 19:56 ` [patch, rfc] " Ulrich Weigand
2010-04-09 16:15 ` Ulrich Weigand
2010-04-12 20:24 ` Joel Brobecker [this message]
2010-06-11 13:48 ` [patch, rfc, v2] " Ulrich Weigand
2010-06-21 16:53 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100412202337.GD19194@adacore.com \
--to=brobecker@adacore.com \
--cc=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox