From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11502 invoked by alias); 12 Apr 2010 20:24:05 -0000 Received: (qmail 11493 invoked by uid 22791); 12 Apr 2010 20:24:04 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Apr 2010 20:23:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 46BFE2BABA2; Mon, 12 Apr 2010 16:23:54 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vHnlrXNnZnX8; Mon, 12 Apr 2010 16:23:54 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id ACACA2BAB99; Mon, 12 Apr 2010 16:23:53 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7C788F58C2; Mon, 12 Apr 2010 13:23:37 -0700 (PDT) Date: Mon, 12 Apr 2010 20:24:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org, Daniel Jacobowitz Subject: Re: [patch, rfc] Re: MIPS dwarf2 location lists Message-ID: <20100412202337.GD19194@adacore.com> References: <201003031955.o23Jtp4w007044@d12av02.megacenter.de.ibm.com> <201004091615.o39GFgl3032201@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201004091615.o39GFgl3032201@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00386.txt.bz2 > > * dwarf2expr.c (dwarf2_read_address): Make static. > > * dwarf2expr.h (dwarf2_read_address): Remove prototype. > > * dwarf2loc.c (find_location_expression): Add relocation offset > > to base-address-selection entry base addresses. Read addresses > > (and offsets) as signed/unsigned integers, depending on the > > BFD's sign_extend_vma flag. Do not call dwarf2_read_address. > > (locexpr_describe_location): Read TLS offset as unsigned > > integer. Do not call dwarf2_read_address. > > Ping. Any thoughts on whether we should go with this? Can't really say much about the patch itself; but FWIW, I tested it on mips-irix, and saw no regression. -- Joel