From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: add helper macros for branch profiling
Date: Mon, 12 Apr 2010 16:09:00 -0000 [thread overview]
Message-ID: <20100412160925.GY19194@adacore.com> (raw)
In-Reply-To: <201004121201.31109.vapier@gentoo.org>
> > > 2010-04-10 Mike Frysinger <vapier@gentoo.org>
> > >
> > > * sim-profile.h (PROFILE_BRANCH_TAKEN, PROFILE_BRANCH_UNTAKEN): New
> > > defines.
> >
> > Forgive my ignorance, but are these macros going to be automatically
> > used? Or is there another patch in the pipeline that makes use of them?
>
> i'm using them in the Blackfin sim. once i can get the Blackfin FDPIC shared
> lib stuff working with latest GDB again, i'll post that patch series.
OK - after some thoughts, I think it's fine for you to check the code in,
even if it's unused. I usually don't like that, but since you already
posted the patch, hopefully it won't be too long before you start using it.
The risk you're exposing yourself to is that someones figures out that
it's unused, and just removes it. But I think it's very remote, at least
in the simulator code.
--
Joel
prev parent reply other threads:[~2010-04-12 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 18:58 Mike Frysinger
2010-04-12 14:54 ` Joel Brobecker
2010-04-12 16:02 ` Mike Frysinger
2010-04-12 16:09 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100412160925.GY19194@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox