From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24704 invoked by alias); 12 Apr 2010 16:09:47 -0000 Received: (qmail 24692 invoked by uid 22791); 12 Apr 2010 16:09:45 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Apr 2010 16:09:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5CF782BAB8F; Mon, 12 Apr 2010 12:09:39 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dvuFvgdOJLE6; Mon, 12 Apr 2010 12:09:39 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2B4DE2BAB8D; Mon, 12 Apr 2010 12:09:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0694AF58C2; Mon, 12 Apr 2010 09:09:25 -0700 (PDT) Date: Mon, 12 Apr 2010 16:09:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: add helper macros for branch profiling Message-ID: <20100412160925.GY19194@adacore.com> References: <1270925865-23799-1-git-send-email-vapier@gentoo.org> <20100412145418.GS19194@adacore.com> <201004121201.31109.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201004121201.31109.vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00364.txt.bz2 > > > 2010-04-10 Mike Frysinger > > > > > > * sim-profile.h (PROFILE_BRANCH_TAKEN, PROFILE_BRANCH_UNTAKEN): New > > > defines. > > > > Forgive my ignorance, but are these macros going to be automatically > > used? Or is there another patch in the pipeline that makes use of them? > > i'm using them in the Blackfin sim. once i can get the Blackfin FDPIC shared > lib stuff working with latest GDB again, i'll post that patch series. OK - after some thoughts, I think it's fine for you to check the code in, even if it's unused. I usually don't like that, but since you already posted the patch, hopefully it won't be too long before you start using it. The risk you're exposing yourself to is that someones figures out that it's unused, and just removes it. But I think it's very remote, at least in the simulator code. -- Joel