[patch] testsuite: non-GNU make compatibility fix

[patch] testsuite: non-GNU make compatibility fix

[Jan Kratochvil]

Hi,

currently on Solaris in gdb/testsuite/:
	make: Fatal error in reader: Makefile, line 177: Extra `:', `::', or `:=' on dependency line

Line 177 is:
	$(filter-out check-gdb.base%,$(TEST_TARGETS)): check-gdb.%: all $(abs_builddir)/site.exp

There is already:
	@GMAKE_TRUE@CHECK_TARGET = $(if $(FORCE_PARALLEL),check-parallel,$(if $(RUNTESTFLAGS),check-single,check-parallel))
	@GMAKE_FALSE@CHECK_TARGET = check-single

The testsuite runs there with this change.


Thanks,
Jan

gdb/testsuite/
2010-04-09  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Fix non-GNU make compatibility.
	* Makefile.in ($(TEST_TARGETS)): Conditionalize it by @GMAKE_TRUE@.

--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -174,9 +174,9 @@ check-parallel:
 	$(SHELL) $(srcdir)/dg-extract-results.sh -L \
 	  $(addsuffix /gdb.log,$(TEST_DIRS)) > gdb.log
 
-$(filter-out check-gdb.base%,$(TEST_TARGETS)): check-gdb.%: all $(abs_builddir)/site.exp
-	@if test ! -d gdb.$*; then mkdir gdb.$*; fi
-	$(DO_RUNTEST) --directory=gdb.$* --outdir=gdb.$* $(RUNTESTFLAGS)
+@GMAKE_TRUE@$(filter-out check-gdb.base%,$(TEST_TARGETS)): check-gdb.%: all $(abs_builddir)/site.exp
+@GMAKE_TRUE@	@if test ! -d gdb.$*; then mkdir gdb.$*; fi
+@GMAKE_TRUE@	$(DO_RUNTEST) --directory=gdb.$* --outdir=gdb.$* $(RUNTESTFLAGS)
 
 # Each half (roughly) of the .exp files from gdb.base.
 BASE1_FILES = $(patsubst $(srcdir)/%,%,$(wildcard $(srcdir)/gdb.base/[a-m]*.exp))

Re: [patch] testsuite: non-GNU make compatibility fix

[Tom Tromey]

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> gdb/testsuite/
Jan> 2010-04-09  Jan Kratochvil  <jan.kratochvil@redhat.com>
Jan> 	Fix non-GNU make compatibility.
Jan> 	* Makefile.in ($(TEST_TARGETS)): Conditionalize it by @GMAKE_TRUE@.

This is ok, thanks.

Tom

Re: [patch] testsuite: non-GNU make compatibility fix

[Jan Kratochvil]

On Fri, 09 Apr 2010 22:46:06 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> gdb/testsuite/
> Jan> 2010-04-09  Jan Kratochvil  <jan.kratochvil@redhat.com>
> Jan> 	Fix non-GNU make compatibility.
> Jan> 	* Makefile.in ($(TEST_TARGETS)): Conditionalize it by @GMAKE_TRUE@.
> 
> This is ok, thanks.

Checked-in:
	http://sourceware.org/ml/gdb-cvs/2010-04/msg00084.html


Thanks,
Jan