* PATCH: Replace abort with internal_error in i387-tdep.c
@ 2010-04-08 22:57 H.J. Lu
2010-04-08 23:33 ` Joel Brobecker
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2010-04-08 22:57 UTC (permalink / raw)
To: GDB
Hi,
This patch replaces abort with internal_error. OK to install?
Thanks.
H.J.
---
2010-04-08 H.J. Lu <hongjiu.lu@intel.com>
* i387-tdep.c (i387_collect_xsave): Replace abort with
internal_error.
diff --git a/gdb/i387-tdep.c b/gdb/i387-tdep.c
index eac3216..6dc9c2c 100644
--- a/gdb/i387-tdep.c
+++ b/gdb/i387-tdep.c
@@ -1033,7 +1033,8 @@ i387_collect_xsave (const struct regcache *regcache, int regnum,
switch (regclass)
{
default:
- abort ();
+ internal_error (__FILE__, __LINE__,
+ _("invalid i387 regclass"));
case avxh:
/* This is an upper YMM register. */
@@ -1077,7 +1078,8 @@ i387_collect_xsave (const struct regcache *regcache, int regnum,
switch (regclass)
{
default:
- abort ();
+ internal_error (__FILE__, __LINE__,
+ _("invalid i387 regclass"));
case all:
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH: Replace abort with internal_error in i387-tdep.c
2010-04-08 22:57 PATCH: Replace abort with internal_error in i387-tdep.c H.J. Lu
@ 2010-04-08 23:33 ` Joel Brobecker
0 siblings, 0 replies; 2+ messages in thread
From: Joel Brobecker @ 2010-04-08 23:33 UTC (permalink / raw)
To: H.J. Lu; +Cc: GDB
> 2010-04-08 H.J. Lu <hongjiu.lu@intel.com>
>
> * i387-tdep.c (i387_collect_xsave): Replace abort with
> internal_error.
This is obvious enough that you can go ahead with this version
of the patch. If Mark has some extra comments, we can make the
necessary adjustments as a followup.
--
Joel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-08 23:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-08 22:57 PATCH: Replace abort with internal_error in i387-tdep.c H.J. Lu
2010-04-08 23:33 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox