Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
Cc: pierre.muller@ics-cnrs.unistra.fr, gdb-patches@sourceware.org
Subject: Re: [RFC] Fix for Go32-v2 native woes
Date: Tue, 06 Apr 2010 18:41:00 -0000	[thread overview]
Message-ID: <201004061841.o36If19m004817@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <83iq84xyoa.fsf@gnu.org> (message from Eli Zaretskii on Tue, 06 	Apr 2010 20:45:25 +0300)

> Date: Tue, 06 Apr 2010 20:45:25 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> > Date: Tue, 6 Apr 2010 16:15:05 +0200
> > 
> >   I finally managed to find a fix, but it is not straightforward:
> >   I had to add a new xml file in features/i386 directory
> > specific for go32v2 target, that does not read i386-sse.xml.
> >   I had to adapt the code in i386-tdep.c to support
> > missing feature_vector and to set tdesc to
> > tdesc_i386_go32v2 instead of tdesc_i386 when go32v2
> > osabi was detected.
> > 
> >   This allows me to use CVS GDB on DJGPP again.
> > 
> >   I checked with a testsuite run on gcc-farm that nothing changed
> > for at least that other target (amd64-linux).
> > 
> >   Similar fixes might be required for other 'old'
> > i386 targets that do not support SSE registers.
> > 
> >   Comments welcome as usual!
> 
> Thanks.  But I really hope that a much more elegant solution could be
> found.  A general layer of code such as i386-tdep.c should not include
> any code that is specific to certain targets.
> 
> Why do we always read i386-sse.xml or assume that SSE is supported?
> We should not assume any CPU features by default if there are CPUs out
> there which we support that don't have them.

Because that basically was the situation before.  When SSE support was
addid we didn't really have a way to detect whether a target supported
SSE or not.

Does Go32 really have no support for the SSE registers?


  reply	other threads:[~2010-04-06 18:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <002a01cad517$d36eab90$7a4c02b0$%muller@ics-cnrs.unistra.fr>
     [not found] ` <001801cad593$8e70daf0$ab5290d0$%muller@ics-cnrs.unistra.fr>
2010-04-06 17:46   ` Eli Zaretskii
2010-04-06 18:41     ` Mark Kettenis [this message]
2010-04-07  3:23       ` Eli Zaretskii
2010-04-07  3:20     ` Eli Zaretskii
2010-04-07  6:19       ` H.J. Lu
2010-04-07  6:44         ` Eli Zaretskii
2010-04-07 14:41           ` Daniel Jacobowitz
2010-04-07 17:34             ` Eli Zaretskii
2010-04-07 17:37               ` H.J. Lu
2010-04-06 17:48 ` Eli Zaretskii
     [not found] <1242886820451223367@unknownmsgid>
2010-04-07  6:32 ` [RFC] Fix for " H.J. Lu
2010-04-07 17:35   ` H.J. Lu
2010-04-07 17:53     ` Eli Zaretskii
2010-04-07 18:01       ` H.J. Lu
     [not found] <002a01cad517$d36eab90$7a4c02b0$@muller@ics-cnrs.unistra.fr>
2010-04-06 14:15 ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004061841.o36If19m004817@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox