From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6456 invoked by alias); 6 Apr 2010 18:41:25 -0000 Received: (qmail 6406 invoked by uid 22791); 6 Apr 2010 18:41:20 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Apr 2010 18:41:16 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o36If2h3013272; Tue, 6 Apr 2010 20:41:02 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o36If19m004817; Tue, 6 Apr 2010 20:41:01 +0200 (CEST) Date: Tue, 06 Apr 2010 18:41:00 -0000 Message-Id: <201004061841.o36If19m004817@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: eliz@gnu.org CC: pierre.muller@ics-cnrs.unistra.fr, gdb-patches@sourceware.org In-reply-to: <83iq84xyoa.fsf@gnu.org> (message from Eli Zaretskii on Tue, 06 Apr 2010 20:45:25 +0300) Subject: Re: [RFC] Fix for Go32-v2 native woes References: <002a01cad517$d36eab90$7a4c02b0$%muller@ics-cnrs.unistra.fr> <001801cad593$8e70daf0$ab5290d0$%muller@ics-cnrs.unistra.fr> <83iq84xyoa.fsf@gnu.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00104.txt.bz2 > Date: Tue, 06 Apr 2010 20:45:25 +0300 > From: Eli Zaretskii > > > From: "Pierre Muller" > > Date: Tue, 6 Apr 2010 16:15:05 +0200 > > > > I finally managed to find a fix, but it is not straightforward: > > I had to add a new xml file in features/i386 directory > > specific for go32v2 target, that does not read i386-sse.xml. > > I had to adapt the code in i386-tdep.c to support > > missing feature_vector and to set tdesc to > > tdesc_i386_go32v2 instead of tdesc_i386 when go32v2 > > osabi was detected. > > > > This allows me to use CVS GDB on DJGPP again. > > > > I checked with a testsuite run on gcc-farm that nothing changed > > for at least that other target (amd64-linux). > > > > Similar fixes might be required for other 'old' > > i386 targets that do not support SSE registers. > > > > Comments welcome as usual! > > Thanks. But I really hope that a much more elegant solution could be > found. A general layer of code such as i386-tdep.c should not include > any code that is specific to certain targets. > > Why do we always read i386-sse.xml or assume that SSE is supported? > We should not assume any CPU features by default if there are CPUs out > there which we support that don't have them. Because that basically was the situation before. When SSE support was addid we didn't really have a way to detect whether a target supported SSE or not. Does Go32 really have no support for the SSE registers?