From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] ARI fix: remove remaining %ll occurences.
Date: Mon, 05 Apr 2010 16:38:00 -0000 [thread overview]
Message-ID: <20100405163845.GE19194@adacore.com> (raw)
In-Reply-To: <002401cad1ab$a8163180$f8429480$@muller@ics-cnrs.unistra.fr>
> As there is no way LONGEST can be specified for scanf,
> I took the option to allow %ll inside scanf calls.
I don't have a better alternative to propose. Since this does not seem
to be a portability issue so far, I'm OK with that.
> 2010-04-01 Pierre Muller <muller@ics.u-strasbg.fr>
>
> Remove remaining "%ll" uses.
> * go32-nat.c (go32_pte_for_address): Replace "0x%llx" using
> hex_string call.
> * rs6000-nat.c (rs6000_ptrace64): Idem.
> * solib-pa64.c (pa64_current_sos): Idem.
> * solib-spu.c (spu_current_sos): Idem.
> * linux-nat.c (linux_nat_find_memory_regions): Replace "%lld" using
> plongest call.
> * nto-procfs.c (procfs_meminfo): Replace "0x%016llx" using
> phex (VAR, 8) call.
> * sh64-tdep.c (sh64_show_media_regs): Idem.
Just one typo, but otherwise approved. Thank you for doing that.
> - ("PC=%s SR=%016llx \n",
> + ("PC=%s SR=%s \n",
> phex (get_frame_register_unsigned (frame,
> gdbarch_pc_regnum (gdbarch)), 8),
> - (long long) get_frame_register_unsigned (frame, SR_REGNUM));
> + phex (get_frame_register_unsigned (frame, SR_REGNUM), 9));
^^^^
Typo: Should be 8.
--
Joel
next prev parent reply other threads:[~2010-04-05 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 14:57 Pierre Muller
2010-04-05 16:38 ` Joel Brobecker [this message]
2010-04-05 22:19 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100405163845.GE19194@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox