From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 438 invoked by alias); 5 Apr 2010 16:38:56 -0000 Received: (qmail 428 invoked by uid 22791); 5 Apr 2010 16:38:54 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Apr 2010 16:38:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 71EA52BAB16; Mon, 5 Apr 2010 12:38:49 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5z5Ul2WRwNaF; Mon, 5 Apr 2010 12:38:49 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3EA252BAB01; Mon, 5 Apr 2010 12:38:49 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 71D6FF58C2; Mon, 5 Apr 2010 09:38:45 -0700 (PDT) Date: Mon, 05 Apr 2010 16:38:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFA] ARI fix: remove remaining %ll occurences. Message-ID: <20100405163845.GE19194@adacore.com> References: <002401cad1ab$a8163180$f8429480$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <002401cad1ab$a8163180$f8429480$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00078.txt.bz2 > As there is no way LONGEST can be specified for scanf, > I took the option to allow %ll inside scanf calls. I don't have a better alternative to propose. Since this does not seem to be a portability issue so far, I'm OK with that. > 2010-04-01 Pierre Muller > > Remove remaining "%ll" uses. > * go32-nat.c (go32_pte_for_address): Replace "0x%llx" using > hex_string call. > * rs6000-nat.c (rs6000_ptrace64): Idem. > * solib-pa64.c (pa64_current_sos): Idem. > * solib-spu.c (spu_current_sos): Idem. > * linux-nat.c (linux_nat_find_memory_regions): Replace "%lld" using > plongest call. > * nto-procfs.c (procfs_meminfo): Replace "0x%016llx" using > phex (VAR, 8) call. > * sh64-tdep.c (sh64_show_media_regs): Idem. Just one typo, but otherwise approved. Thank you for doing that. > - ("PC=%s SR=%016llx \n", > + ("PC=%s SR=%s \n", > phex (get_frame_register_unsigned (frame, > gdbarch_pc_regnum (gdbarch)), 8), > - (long long) get_frame_register_unsigned (frame, SR_REGNUM)); > + phex (get_frame_register_unsigned (frame, SR_REGNUM), 9)); ^^^^ Typo: Should be 8. -- Joel