Re: [RFC-v2] Support for const char and strings in stabs reader

[Joel Brobecker <brobecker@adacore.com>]

> > As a general comment, the formatting of the section supporting strings
> > is not consistent. It looks like it's because you have a mixture of
> > spaces and tabs...
>  Strange because I now use the script recently given on gdb mailing list
> to avoid such problems...

The tricks for the .vimrc file is not a silver bullet ensuring that all
lines start with tabs instead of using blocks of 8 spaces. What it only
does is use tabs instead of spaces when creating a new line. Some parts
of your patch have lines that start with a space, then a tab, then more
spaces...

When you need to see spaces and tabs, I recommend the following setting:

        :set list

I cannot help shaking my head as to how much grief this spaces vs tabs
thing is causing. It's insane, IMO, to be clinging to tabs in our
programming style. But I've fought and lost that battle before...


> 2010-03-24  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
> 	* stabsread.c (define_symbol): Add support for char
> 	and string constants.

This is OK, after you make sure to format the code properly (spaces
and tabs).

> testsuite ChangeLog entry:
> 
> 	* gdb.stabs/aout.sed: Convert all backslash to double backslash
> 	within one line, unless it is followed by a double quote.
> 	* gdb.stabs/hppa.sed: Idem.
> 	* gdb.stabs/weird.def: Add char and String constants
> 	* gdb.stabs/weird.exp: Check for correct parsing of 
> 	chhar and string constants.
> 	* gdb.stabs/xcoff.sed: Ignore escaped quote quotes
> 	in .stabs to .stabx substitution.

OK, except for one tiny hunk that I suspect got in unintentionally:

> @@ -287,7 +298,7 @@ if  { [gdb_compile "${srcfile}" "${binfi
>       return -1
>  }
>  
> -remote_file build delete ${srcfile}
> +# remote_file build delete ${srcfile}
>  
>  # Start with a fresh gdb
>  gdb_exit

This change was probably not meant to go in.

-- 
Joel