From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14686 invoked by alias); 5 Apr 2010 15:19:30 -0000 Received: (qmail 14676 invoked by uid 22791); 5 Apr 2010 15:19:28 -0000 X-SWARE-Spam-Status: No, hits=3.6 required=5.0 tests=BAYES_00,KAM_STOCKTIP X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Apr 2010 15:19:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F27A22BAB03; Mon, 5 Apr 2010 11:19:20 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id JIGeaWXFtkHn; Mon, 5 Apr 2010 11:19:20 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 569692BAB94; Mon, 5 Apr 2010 11:19:20 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5A35FF58C2; Mon, 5 Apr 2010 08:19:16 -0700 (PDT) Date: Mon, 05 Apr 2010 15:19:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFC-v2] Support for const char and strings in stabs reader Message-ID: <20100405151916.GB19194@adacore.com> References: <000201cac54d$246dcdd0$6d496970$@muller@ics-cnrs.unistra.fr> <20100323185314.GA2882@adacore.com> <000601cacba5$0463eb60$0d2bc220$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000601cacba5$0463eb60$0d2bc220$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00073.txt.bz2 > > As a general comment, the formatting of the section supporting strings > > is not consistent. It looks like it's because you have a mixture of > > spaces and tabs... > Strange because I now use the script recently given on gdb mailing list > to avoid such problems... The tricks for the .vimrc file is not a silver bullet ensuring that all lines start with tabs instead of using blocks of 8 spaces. What it only does is use tabs instead of spaces when creating a new line. Some parts of your patch have lines that start with a space, then a tab, then more spaces... When you need to see spaces and tabs, I recommend the following setting: :set list I cannot help shaking my head as to how much grief this spaces vs tabs thing is causing. It's insane, IMO, to be clinging to tabs in our programming style. But I've fought and lost that battle before... > 2010-03-24 Pierre Muller > > * stabsread.c (define_symbol): Add support for char > and string constants. This is OK, after you make sure to format the code properly (spaces and tabs). > testsuite ChangeLog entry: > > * gdb.stabs/aout.sed: Convert all backslash to double backslash > within one line, unless it is followed by a double quote. > * gdb.stabs/hppa.sed: Idem. > * gdb.stabs/weird.def: Add char and String constants > * gdb.stabs/weird.exp: Check for correct parsing of > chhar and string constants. > * gdb.stabs/xcoff.sed: Ignore escaped quote quotes > in .stabs to .stabx substitution. OK, except for one tiny hunk that I suspect got in unintentionally: > @@ -287,7 +298,7 @@ if { [gdb_compile "${srcfile}" "${binfi > return -1 > } > > -remote_file build delete ${srcfile} > +# remote_file build delete ${srcfile} > > # Start with a fresh gdb > gdb_exit This change was probably not meant to go in. -- Joel