From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: hjl.tools@gmail.com
Cc: gdb-patches@sourceware.org
Subject: Re: PING: PATCH: Support "ah", "bh", "ch", "dh" in amd64
Date: Thu, 01 Apr 2010 19:21:00 -0000 [thread overview]
Message-ID: <201004011920.o31JKjKZ013941@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20100401131339.GA3457@intel.com> (hongjiu.lu@intel.com)
> Date: Thu, 1 Apr 2010 06:13:39 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
>
> On Wed, Mar 03, 2010 at 12:53:13PM -0800, H.J. Lu wrote:
> > Hi,
> >
> > AMD64 can access "ah", "bh", "ch", "dh". I missed them in my x86
> > pseudo register support. This patch adds them. OK to install?
> >
> > Thanks.
> >
> >
> > H.J.
> > ---
> > gdb/
> >
> > 2010-03-03 H.J. Lu <hongjiu.lu@intel.com>
> >
> > * amd64-tdep.c (amd64_byte_names): Add "ah", "bh", "ch", "dh".
> > (amd64_pseudo_register_read): Handle "ah", "bh", "ch", "dh".
> > (amd64_pseudo_register_write): Likewise.
> > (amd64_init_abi): Set num_byte_regs to 20.
> >
> > gdb/testsuite/
> >
> > 2010-03-03 H.J. Lu <hongjiu.lu@intel.com>
> >
> > * gdb.arch/amd64-byte.exp: Check "ah", "bh", "ch", "dh".
> >
>
> PING.
Sorry; this dropped off my radar;
+ if (gpnum >= 16)
can you replace that magic constant with a proper #define?
next prev parent reply other threads:[~2010-04-01 19:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 20:53 H.J. Lu
2010-03-12 6:06 ` PATCH: Restore "sp" and support " H.J. Lu
2010-03-12 8:32 ` Eli Zaretskii
2010-03-12 14:30 ` H.J. Lu
2010-03-12 15:31 ` Eli Zaretskii
2010-03-12 9:27 ` Mark Kettenis
2010-03-12 14:20 ` PATCH: Support " H.J. Lu
2010-04-01 13:13 ` PING: " H.J. Lu
2010-04-01 19:21 ` Mark Kettenis [this message]
2010-04-01 19:43 ` H.J. Lu
2010-04-01 19:42 ` H.J. Lu
2010-04-01 19:52 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004011920.o31JKjKZ013941@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox