From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71704-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10687 invoked by alias); 1 Apr 2010 19:21:02 -0000
Received: (qmail 10654 invoked by uid 22791); 1 Apr 2010 19:21:00 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Apr 2010 19:20:55 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o31JKkg5003529; 	Thu, 1 Apr 2010 21:20:46 +0200 (CEST)
Received: (from kettenis@localhost) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o31JKjKZ013941; 	Thu, 1 Apr 2010 21:20:45 +0200 (CEST)
Date: Thu, 01 Apr 2010 19:21:00 -0000
Message-Id: <201004011920.o31JKjKZ013941@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: hjl.tools@gmail.com
CC: gdb-patches@sourceware.org
In-reply-to: <20100401131339.GA3457@intel.com> (hongjiu.lu@intel.com)
Subject: Re: PING: PATCH: Support "ah", "bh", "ch", "dh" in amd64
References: <20100303205313.GA25695@intel.com> <20100401131339.GA3457@intel.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00023.txt.bz2

> Date: Thu, 1 Apr 2010 06:13:39 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> 
> On Wed, Mar 03, 2010 at 12:53:13PM -0800, H.J. Lu wrote:
> > Hi,
> > 
> > AMD64 can access "ah", "bh", "ch", "dh".  I missed them in my x86
> > pseudo register support.  This patch adds them. OK to install?
> > 
> > Thanks.
> > 
> > 
> > H.J.
> > ---
> > gdb/
> > 
> > 2010-03-03  H.J. Lu  <hongjiu.lu@intel.com>
> > 
> > 	* amd64-tdep.c (amd64_byte_names): Add "ah", "bh", "ch", "dh".
> > 	(amd64_pseudo_register_read): Handle "ah", "bh", "ch", "dh".
> > 	(amd64_pseudo_register_write): Likewise.
> > 	(amd64_init_abi): Set num_byte_regs to 20.
> > 
> > gdb/testsuite/
> > 
> > 2010-03-03  H.J. Lu  <hongjiu.lu@intel.com>
> > 
> > 	* gdb.arch/amd64-byte.exp: Check "ah", "bh", "ch", "dh".
> > 
> 
> PING.

Sorry; this dropped off my radar;

+      if (gpnum >= 16)

can you replace that magic constant with a proper #define?