From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Cc: "Hans-Peter Nilsson" <hp@bitrange.com>
Subject: Re: [PATCH] sim: constify watchpoint interrupt names
Date: Tue, 30 Mar 2010 23:07:00 -0000 [thread overview]
Message-ID: <201003301907.28723.vapier@gentoo.org> (raw)
In-Reply-To: <alpine.BSF.2.00.1003301847550.72375@dair.pair.com>
[-- Attachment #1: Type: Text/Plain, Size: 1346 bytes --]
On Tuesday 30 March 2010 18:53:17 Hans-Peter Nilsson wrote:
> On Mon, 29 Mar 2010, Mike Frysinger wrote:
> > * sim-watch.h (struct _sim_watchpoints): Add const to interrupt_names.
>
> Either the above or one of your other committs to this area,
> caused, for v850-elf (beware of linewrapped cutnpaste):
it was this one
> /tmp/hpautotest-sim/src/sim/v850/interp.c: In function
> 'do_interrupt':
> /tmp/hpautotest-sim/src/sim/v850/interp.c:70: error: invalid
> operands to binary -
> /tmp/hpautotest-sim/src/sim/v850/interp.c: In function
> 'sim_open':
> /tmp/hpautotest-sim/src/sim/v850/interp.c:210: warning:
> assignment from incompatible pointer type
this should fix it:
RCS file: /cvs/src/src/sim/v850/interp.c,v
retrieving revision 1.4
diff -u -p -r1.4 interp.c
--- interp.c 5 Sep 2003 17:46:52 -0000 1.4
+++ interp.c 30 Mar 2010 23:06:58 -0000
@@ -48,7 +48,7 @@ enum interrupt_type
num_int_types
};
-char *interrupt_names[] = {
+const char *interrupt_names[] = {
"reset",
"nmi",
"intov1",
@@ -65,7 +65,7 @@ do_interrupt (sd, data)
SIM_DESC sd;
void *data;
{
- char **interrupt_name = (char**)data;
+ const char **interrupt_name = (const char**)data;
enum interrupt_type inttype;
inttype = (interrupt_name - STATE_WATCHPOINTS (sd)->interrupt_names);
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-03-30 23:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 21:49 Mike Frysinger
2010-03-30 16:19 ` Tom Tromey
2010-03-30 22:53 ` Hans-Peter Nilsson
2010-03-30 23:07 ` Mike Frysinger [this message]
2010-03-30 23:21 ` Hans-Peter Nilsson
2010-03-30 23:42 ` Mike Frysinger
2010-03-31 1:20 ` Doug Evans
2010-03-31 1:46 ` Hans-Peter Nilsson
2010-03-31 3:42 ` Mike Frysinger
2010-03-31 23:43 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003301907.28723.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=hp@bitrange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox