From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16636 invoked by alias); 30 Mar 2010 23:07:48 -0000 Received: (qmail 16626 invoked by uid 22791); 30 Mar 2010 23:07:47 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Mar 2010 23:07:40 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id D94431B40E0; Tue, 30 Mar 2010 23:07:38 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: constify watchpoint interrupt names Date: Tue, 30 Mar 2010 23:07:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33.1; KDE/4.4.1; x86_64; ; ) Cc: "Hans-Peter Nilsson" References: <1269899363-10054-1-git-send-email-vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1384589.06JBIECsjb"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201003301907.28723.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01097.txt.bz2 --nextPart1384589.06JBIECsjb Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1319 On Tuesday 30 March 2010 18:53:17 Hans-Peter Nilsson wrote: > On Mon, 29 Mar 2010, Mike Frysinger wrote: > > * sim-watch.h (struct _sim_watchpoints): Add const to interrupt_names. >=20 > Either the above or one of your other committs to this area, > caused, for v850-elf (beware of linewrapped cutnpaste): it was this one > /tmp/hpautotest-sim/src/sim/v850/interp.c: In function > 'do_interrupt': > /tmp/hpautotest-sim/src/sim/v850/interp.c:70: error: invalid > operands to binary - > /tmp/hpautotest-sim/src/sim/v850/interp.c: In function > 'sim_open': > /tmp/hpautotest-sim/src/sim/v850/interp.c:210: warning: > assignment from incompatible pointer type this should fix it: RCS file: /cvs/src/src/sim/v850/interp.c,v retrieving revision 1.4 diff -u -p -r1.4 interp.c --- interp.c 5 Sep 2003 17:46:52 -0000 1.4 +++ interp.c 30 Mar 2010 23:06:58 -0000 @@ -48,7 +48,7 @@ enum interrupt_type num_int_types }; =20 -char *interrupt_names[] =3D { +const char *interrupt_names[] =3D { "reset", "nmi", "intov1", @@ -65,7 +65,7 @@ do_interrupt (sd, data) SIM_DESC sd; void *data; { - char **interrupt_name =3D (char**)data; + const char **interrupt_name =3D (const char**)data; enum interrupt_type inttype; inttype =3D (interrupt_name - STATE_WATCHPOINTS (sd)->interrupt_names); =20 -mike --nextPart1384589.06JBIECsjb Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLsoQwAAoJEEFjO5/oN/WBVJgQAOIFSqTNgl30tXDdpSQKGgYk HNjxywgU9mH2CLLLnGqwcVxwAPRg70aT7E5YO1FoGeZExnl0SdtunEkc7xWXD4G6 eM8zjI5kSkFA+L8VVs1ZurufnW1NrIfJBTGGP/ppl7qHjDfVF/wiK9zI6I00NW94 6ib0GOKddPmYn3EtQoHP5RCq3S+pbZQOjWejx74rvJK24FyhU58V3G25SssTrLDP v9aCurS0z7Y1Nh0Ymwx1eFDoCPseFxegD8o/WAGcPwDJx2ZgOUhdy+NBmfDrAg50 W6iZs/HNOj0L2q8jhvTEHFRXfhKZsxdGpToA4n+OjkOD6XPoYwMWUFD3C7yXXC/s sx7ZBTwI+dUyG0/FNoKTmiQIsSUzLx6JNKOXN/23lmTdVL2gpcAiBrYjSWjWHand QjQZ3fOjoS/ceWMg8TUN7LNaQJajJ2hMZ/JYUyeLClrYPCL9kGTTPUJr9eJnk/yr B9T9YMEvM4rRRqGRuD8m2qppwLEwVHqwZcInHle19b9kIvnj3B9fhT1ntp2wlUSx XJzawi2Ofwd6VnVMdVS/5cIE5qmYBWf4QVgYwn4HsqaqW22Y81a5sBLlsPdp8V2q 7xSxIqle8JfwM7DR92h+8IqXCKgWSwdBWUEP8Wl4AQH2aPIWO4Ph5U7WoUCCkuhW ly3XhHOMAIinsXGniM46 =eJac -----END PGP SIGNATURE----- --nextPart1384589.06JBIECsjb--