From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: [MI tracepoints 2/9] unify breakpoint commands and tracepoint actions
Date: Tue, 16 Mar 2010 00:56:00 -0000 [thread overview]
Message-ID: <201003160056.13258.pedro@codesourcery.com> (raw)
In-Reply-To: <201003141147.34051.vladimir@codesourcery.com>
Is this the final patch? I ask because I'm seeing some of the same
issues that I pointed out before offlist.
On Sunday 14 March 2010 08:47:33, Vladimir Prus wrote:
> + /** We need to verify that each top-level element of commands
> + is valid for tracepoints, that there's at most one while-stepping
> +#gdb_test "info tracepoints" \
> +# "Num Type\[ \]+Disp Enb Address\[ \]+What.*
> +#.*while-stepping $stepcount.*" \
> +
> +
> +
Please also fix this:
> @@ -252,6 +252,8 @@ mi_cmd_break_commands (char *command, char **argv, int argc)
> int bnum;
> struct breakpoint *b;
>
> + extern void check_tracepoint_command (char *line, void *closure);
This is not a review.
--
Pedro Alves
prev parent reply other threads:[~2010-03-16 0:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 8:47 Vladimir Prus
2010-03-15 17:48 ` Stan Shebs
2010-03-15 21:00 ` Tom Tromey
2010-03-16 11:38 ` Vladimir Prus
2010-03-22 15:01 ` Stan Shebs
2010-03-23 21:37 ` Vladimir Prus
2010-03-16 0:56 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003160056.13258.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox