From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32395 invoked by alias); 16 Mar 2010 00:56:22 -0000 Received: (qmail 32384 invoked by uid 22791); 16 Mar 2010 00:56:21 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Mar 2010 00:56:17 +0000 Received: (qmail 15881 invoked from network); 16 Mar 2010 00:56:15 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Mar 2010 00:56:15 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [MI tracepoints 2/9] unify breakpoint commands and tracepoint actions Date: Tue, 16 Mar 2010 00:56:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; ) Cc: Vladimir Prus References: <201003141147.34051.vladimir@codesourcery.com> In-Reply-To: <201003141147.34051.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003160056.13258.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00573.txt.bz2 Is this the final patch? I ask because I'm seeing some of the same issues that I pointed out before offlist. On Sunday 14 March 2010 08:47:33, Vladimir Prus wrote: > + /** We need to verify that each top-level element of commands > + is valid for tracepoints, that there's at most one while-stepping > +#gdb_test "info tracepoints" \ > +# "Num Type\[ \]+Disp Enb Address\[ \]+What.* > +#.*while-stepping $stepcount.*" \ > + > + > + Please also fix this: > @@ -252,6 +252,8 @@ mi_cmd_break_commands (char *command, char **argv, int argc) > int bnum; > struct breakpoint *b; > > + extern void check_tracepoint_command (char *line, void *closure); This is not a review. -- Pedro Alves