Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: [MI tracepoints 7/9] -trace-find
Date: Tue, 16 Mar 2010 00:28:00 -0000	[thread overview]
Message-ID: <201003160027.53945.pedro@codesourcery.com> (raw)
In-Reply-To: <201003141159.44482.vladimir@codesourcery.com>

I stopped a few minor issues.

On Sunday 14 March 2010 08:59:44, Vladimir Prus wrote:
> +    error ("May not look at trace frames while trace is running.");

Missing i18n.

> +  else if (strcmp (mode, "tracepoint-number") == 0)
> +    {
> +      if (argc != 2)
> +       error (_("frame number is required"));
> +      tfind_1 (tfind_tp, atoi (argv[1]), 0, 0, 0);
> +    }

You mean, "tracepoint number is required".

On Sunday 14 March 2010 08:59:44, Vladimir Prus wrote:
> -      TPP.  */
> +      TPP.  If no trace frame matches, return -1. ay throw if the
                                                   ^^^

"-1.  May throw"

-- 
Pedro Alves


  parent reply	other threads:[~2010-03-16  0:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-14  8:59 Vladimir Prus
2010-03-16  0:20 ` Stan Shebs
2010-03-16  0:28 ` Pedro Alves [this message]
2010-03-16 13:23   ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003160027.53945.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox