From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18985 invoked by alias); 16 Mar 2010 00:28:02 -0000 Received: (qmail 18967 invoked by uid 22791); 16 Mar 2010 00:28:01 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Mar 2010 00:27:58 +0000 Received: (qmail 30967 invoked from network); 16 Mar 2010 00:27:56 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Mar 2010 00:27:56 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [MI tracepoints 7/9] -trace-find Date: Tue, 16 Mar 2010 00:28:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; ) Cc: Vladimir Prus References: <201003141159.44482.vladimir@codesourcery.com> In-Reply-To: <201003141159.44482.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003160027.53945.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00571.txt.bz2 I stopped a few minor issues. On Sunday 14 March 2010 08:59:44, Vladimir Prus wrote: > + error ("May not look at trace frames while trace is running."); Missing i18n. > + else if (strcmp (mode, "tracepoint-number") == 0) > + { > + if (argc != 2) > + error (_("frame number is required")); > + tfind_1 (tfind_tp, atoi (argv[1]), 0, 0, 0); > + } You mean, "tracepoint number is required". On Sunday 14 March 2010 08:59:44, Vladimir Prus wrote: > - TPP. */ > + TPP. If no trace frame matches, return -1. ay throw if the ^^^ "-1. May throw" -- Pedro Alves